Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

flash hls: video dimensions not honored when container ratio does not match video ratio #1167

Closed
phloxic opened this issue Mar 24, 2017 · 10 comments
Assignees
Milestone

Comments

@phloxic
Copy link
Contributor

phloxic commented Mar 24, 2017

If the container aspect ratio does not match video aspect ratio (or rather video width/height, as this is Flash) the Flash object may not resize in time.

EDIT: This happens with all streams, and is in fact a regression from version 6.x.

@phloxic phloxic changed the title flash hls: video dimensions not honored immediately with certain streams flash hls: video dimensions not honored when container ratio does not match video ratio Mar 25, 2017
@phloxic
Copy link
Contributor Author

phloxic commented Mar 25, 2017

Indeed the first breaking version is 7.0.0.

@nnarhinen
Copy link
Contributor

Is there a way to reproduce this always? I can't reproduce this after the first attempt :(

@phloxic
Copy link
Contributor Author

phloxic commented Mar 25, 2017

I can always repro with simple cache-refresh.

@phloxic
Copy link
Contributor Author

phloxic commented Mar 25, 2017

I think Firefox is the easiest for reproducing.

nnarhinen added a commit that referenced this issue Mar 25, 2017
@nnarhinen nnarhinen added this to the 7.0.3 milestone Mar 25, 2017
@nnarhinen
Copy link
Contributor

@phloxic
Copy link
Contributor Author

phloxic commented Mar 25, 2017

Better, but not as good as v6. With v7 I can see the Flash object resizing, with v6 it's almost unnoticeabl. Strange.
I'll revert to the multiplexed stream, then you should be able to see it clearer.

@nnarhinen
Copy link
Contributor

hmm.... it should now resize already in poster state. Are you sure you have a clean cache?

@nnarhinen
Copy link
Contributor

You will know if you get these lines in this order in console log:

image

@phloxic
Copy link
Contributor Author

phloxic commented Mar 25, 2017

Yes. I also tried various scenarios locally with the assets from dev.94.fp.org.
Let me check again tomorrow, I'm too tired. But in principle it's ok.

@phloxic
Copy link
Contributor Author

phloxic commented Mar 27, 2017

I can observe the resizing with empty cache or after cache refresh in v7 at http://demos.dev94.flowplayer.us/bug/1167.html
Not with v6 at http://demos.dev94.flowplayer.us/bug/1167-v6.html

Note with Chrome's PepperFlash both are ok.
In view of Flash moving off the radar I'm inclined to being ok with this state. The difference may still be worth investigating. In general I have the impression that v5 Flash HLS loads slower, noticeable especially when the (vod-)quality selector is used with Flash HLS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants