This repository has been archived by the owner on Sep 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 472
volume(level, true) changes localStorage.volume when called from within event #1264
Milestone
Comments
Additionally the timing of the localStorage change varies. If I change the demo code from: }).on("ready cuepoint", function (e, api) {
if (e.type === "cuepoint") api.volume(0, true);
document.getElementById("lsvolume").innerHTML = e.type + " -> " + window.localStorage.volume;
}); to }).on("ready cuepoint", function (e, api) {
if (e.type === "cuepoint") api.volume(0, true);
document.getElementById("lsvolume").innerHTML = e.type + " -> " + window.localStorage.volume;
}).one("progress", function (e, api) {
document.getElementById("lsvolume").innerHTML = e.type + " -> " + window.localStorage.volume;
}); The call on cuepoint seems to work, but it doesn't which can be revealed with: }).on("ready cuepoint", function (e, api) {
if (e.type === "cuepoint") api.volume(0, true);
setTimeout(function () {
document.getElementById("lsvolume").innerHTML = e.type + " -> " + window.localStorage.volume;
});
}).one("progress", function (e, api) {
document.getElementById("lsvolume").innerHTML = e.type + " -> " + window.localStorage.volume;
}); That is: a query of localStorage changes the timing of when it is next changed ... |
The same with |
This was referenced Sep 23, 2017
phloxic
added a commit
to flowplayer/flowplayer-background
that referenced
this issue
Sep 23, 2017
Currently api.mute(true, true) and api.volume(0, true) change localStorage when called from within event. cf. flowplayer/flowplayer#1264 Right now users must configure muted. Which is recommended anyway because of: 1. mutedAutoplay 2. Safari 11 - flowplayer/flowplayer#1260
Is this still true in 7.2? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It should skip storage when the 2nd argument is true.
Also localStorage.volume has not changed to conf.volume on ready.
Demo will be available at http://demos.flowplayer.org/bug/1264.html
The text was updated successfully, but these errors were encountered: