test: unit test incompatible environments #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently integration tests cover catching pkgdb build errors when a manifest does not support the current system, or a package does not support the current system. These cases will be faster and more targeted if unit tested instead of integration tested.
- Add a test_helpers module with flox_instance_with_global_lock that ensures pkgdb scrape has been run and then adds a global lock to the flox instance being created. - Move flox_instance to the test_helpers module - Drop FLOX_INSTANCE in favor of flox_instance_with_global_lock. Using a single FLOX_INSTANCE is likely to cause problems when shared between multiple tests because it doesn't isolate tests. flox_instance_with_global_lock will be close to as performant with better isolation.
zmitchell
reviewed
Mar 26, 2024
zmitchell
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently integration tests cover catching pkgdb build errors when a
manifest does not support the current system, or a package does not
support the current system. These cases will be faster and more targeted
if unit tested instead of integration tested.
Dropping integration tests will be done in a followup PR.
Writing these tests revealed there's currently no easy way to avoid a pkgdb scrape in a unit test and use an isolated flox instance, so the following changes were made as well:
ensures pkgdb scrape has been run and then adds a global lock to the
flox instance being created.
single FLOX_INSTANCE is likely to cause problems when shared between
multiple tests because it doesn't isolate tests.
flox_instance_with_global_lock will be close to as performant with
better isolation.