Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: linting #417

Merged
merged 7 commits into from
Dec 31, 2022
Merged

chore: linting #417

merged 7 commits into from
Dec 31, 2022

Conversation

webdeveric
Copy link
Collaborator

  • updated dev dependencies
  • updated linting rules
  • fixes for ☝️ rules

@floydspace
Copy link
Owner

I wanna reuse the ruleset I created a while ago for all my projects https://github.com/floydspace/linters
which is basically a fork from https://github.com/Tinkoff/linters with some additions.

Let me raise the PR. Thank you for spending time on this though.

@webdeveric
Copy link
Collaborator Author

@floydspace Should I close this one? There are some fixes in here that I think should be merged.

@floydspace
Copy link
Owner

Let me continue in your branch. if you don't mind

@floydspace floydspace marked this pull request as draft December 30, 2022 22:08
@floydspace floydspace marked this pull request as ready for review December 30, 2022 23:39
Copy link
Owner

@floydspace floydspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webdeveric done, good if you quickly check the new changes

@floydspace floydspace merged commit 744dbb4 into floydspace:master Dec 31, 2022
@webdeveric webdeveric deleted the chore/linting branch December 31, 2022 15:27
@github-actions
Copy link

🎉 This PR is included in version 1.35.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants