Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint warnings #451

Merged
merged 2 commits into from
Mar 21, 2023
Merged

fix: lint warnings #451

merged 2 commits into from
Mar 21, 2023

Conversation

fredrik
Copy link
Contributor

@fredrik fredrik commented Mar 20, 2023

There were three warnings from eslint, two about console.log and one about BuildResult only used as a type.

floydspace
floydspace approved these changes Mar 20, 2023
View reviewed changes
Copy link
Owner

@floydspace floydspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me, having messages as part of error

@fredrik
Copy link
Contributor Author

fredrik commented Mar 20, 2023

Is your merge strategy to squash PRs into one commit, or do you wish for fixup commits to be squashed by me?

@floydspace floydspace merged commit 9348a73 into floydspace:master Mar 21, 2023
@floydspace
Copy link
Owner

@fredrik I'm squashing, so no worries, sometimes I rewrite message

@github-actions
Copy link

🎉 This PR is included in version 1.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floydspace floydspace floydspace approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrik @floydspace