Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcftbx/utils: fixes for Python 2/3 compatibility #126

Merged
merged 5 commits into from Sep 13, 2019
Merged

bcftbx/utils: fixes for Python 2/3 compatibility #126

merged 5 commits into from Sep 13, 2019

Conversation

pjbriggs
Copy link
Member

PR which updates the bcftbx/utils module to fix compatibility issues between Python 2 and 3, including:

  • Fixing relative imports in unit tests
  • Removing xrange in favour of forwards-compatible range function
  • Reimplementing use of max built-in function to handle None values
  • Updating getlines to explicitly read data as text
  • Fixing unit tests for concatenate_fastq_files when handling gzipped Fastqs

@pjbriggs pjbriggs merged commit 8e4f00c into devel Sep 13, 2019
@pjbriggs pjbriggs deleted the bcftbx-utils-fixes-for-python3-compatibility branch September 13, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix python3 refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pjbriggs