[Matrix] API change update / cleanups #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait with merge, there comes also another part on API! |
|
Thanks again for keeping this pvr addon API compatible! I am busy these days which may delay merge&release. I sent you an invitation to this project - feel free to merge this PR on your own! |
|
Thanks a lot, will merge it then on end! |
AlwinEsch
force-pushed
the
Matrix-change
branch
from
7909fe1
to
5cdd54a
Compare
AlwinEsch
changed the title
AlwinEsch
force-pushed
the
Matrix-change
branch
from
e44fc70
to
b0dead6
Compare
|
It's time to merge? Feel free, if it is ;) |
AlwinEsch
force-pushed
the
Matrix-change
branch
from
b0dead6
to
c0309d9
Compare
|
Exact 😄, the request on Kodi is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to xbmc/xbmc#17586 and to bring in after them.
Commit 1:
Seen you added the status badges in one line where it makes very long.
This add linebreaks inside, as this it is also shown by Markdown in one line.
Commit 2:
Only set two http to https.
Commit 3:
To have them equal with other addons and prevent some Windows and Mac parts.
Commit 4:
Thought to make this to request on Kodi:
xbmc/xbmc@a6aac07
and remove this deprecated part.
Can you also do a test, it should normally work, but to make sure.