Add new built type based on RelWithDebInfo plus asserts #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up build_type script
g-roma
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new build type for testing. It uses the CMake built-in
RelWithDebInfoas its basis, but removes theNDEBUGflag so that we still have assertions. This means that on Mac / Linux we have something like-O2 -g, i.e. some optimization and debug info, plus assertions.Before merging we just need to agree on the name. Currently it's called
Test, and you'd select it like any other build type. E.g., if using make or ninja as your generatorIf you'd rather it were called something else, now is the time to say.
Before it can be used, I need to add a line to each of the host top level CMakeLists to include the type, but it seems to work just fine.