Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Plotter drag to zoom #158

Merged
merged 8 commits into from
Mar 29, 2022
Merged

[Feature] Plotter drag to zoom #158

merged 8 commits into from
Mar 29, 2022

Conversation

jamesb93
Copy link
Member

@jamesb93 jamesb93 commented Mar 16, 2022 •
edited

Adds the ability to drag a square of an area of the plotter to zoom in.

The shortcut is option + drag for Mac and whatever that translates to on Windows (winkey?)

You can reset the xrange/yrange to whatever was stored via message previously with control + click.

Example can be seen on the final tab of the help file if you want to play with it easily.

@jamesb93 jamesb93 changed the base branch from main to dev March 16, 2022 13:40
@jamesb93 jamesb93 self-assigned this Mar 16, 2022
@jamesb93 jamesb93 added the enhancement New feature or request label Mar 16, 2022
@jamesb93 jamesb93 added this to the beta6 milestone Mar 16, 2022
@jamesb93 jamesb93 marked this pull request as ready for review March 16, 2022 13:42
tedmoore
tedmoore approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@tedmoore tedmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I'll put an issue on the SC repo to mirror functionality. Not sure when that will happen at the moment. But it'll happen!

@tedmoore tedmoore mentioned this pull request Mar 21, 2022
Closed
@jamesb93
Copy link
Member Author

Nice. I'll put an issue on the SC repo to mirror functionality. Not sure when that will happen at the moment. But it'll happen!

Do you want to await that SC change for the merge?

@tedmoore
Copy link
Member

Do you want to await that SC change for the merge?

I think that's a good idea. Should we aim for this to be in beta6?

@jamesb93
Copy link
Member Author

Do you want to await that SC change for the merge?

I think that's a good idea. Should we aim for this to be in beta6?

Yep! Possibly, do you think I could tackle the SC version with your supervision and final say on the code style?

@tedmoore
Copy link
Member

Yep! Possibly, do you think I could tackle the SC version with your supervision and final say on the code style?

I would like to do it.

@jamesb93
Copy link
Member Author

Yep! Possibly, do you think I could tackle the SC version with your supervision and final say on the code style?

I would like to do it.

No problem :) When you make the PR/issue link it up against this one somehow.

@tedmoore
Copy link
Member

When you make the PR/issue link it up against this one somehow.

flucoma/flucoma-sc#84

@jamesb93
Copy link
Member Author

When you make the PR/issue link it up against this one somehow.

flucoma/flucoma-sc#84

🚀

@tremblap
Copy link
Member

this is great and I'll add an issue on Pd (and let's not wait for it because this object is already breaking with PurrData so I'll have to go radical I think...)

@jamesb93 jamesb93 merged commit 6175050 into flucoma:dev Mar 29, 2022
@jamesb93 jamesb93 deleted the enhance/plotter-zoom branch March 29, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedmoore tedmoore tedmoore approved these changes

@tremblap tremblap tremblap approved these changes

@jdchart jdchart Awaiting requested review from jdchart

@weefuzzy weefuzzy Awaiting requested review from weefuzzy

Assignees

@jamesb93 jamesb93

Labels
enhancement New feature or request
Projects
None yet
Milestone
beta6
Development

Successfully merging this pull request may close these issues.

datasetquery crashes max
3 participants
@jamesb93 @tedmoore @tremblap