Introduce stricter ordering for access to mDone atomic in NRT wrapper
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@g-roma had been experiencing occasional and hard-to-reproduce crashes in scsynth, when putting the batch processing via Synths to serious work. By happy accident, I was able to get a crash something that looked similar whilst in a debug build, so I could get some more info.
Looked to me like we needed stricter ordering around access to atomics in order for the Trigger UGen to terminate safely, so this PR introduces that.
Not expecting feedback on code, unless C++ threading stuff is of interest, but if reviewers could confirm that SC continues to work for them, that would be swell.