Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js build #247

Merged
merged 9 commits into from
Aug 18, 2021
Merged

Js build #247

merged 9 commits into from
Aug 18, 2021

Conversation

DieMyst
Copy link
Member

@DieMyst DieMyst commented Aug 18, 2021

use sbt cliJS/fullLinkJS to compile aqua compiler to js
compiled source will be here cli/.js/target/scala-3.0.1/cli-opt/

@DieMyst DieMyst requested a review from alari August 18, 2021 08:51
Copy link
Member

@alari alari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the publishing flow to have the compiled .js file both in the NPM package and as a GitHub release asset.

We shouldn't switch to the JS version in the NPM yet, just deliver it along with the old .jar version to enable experiments.

outputF,
output =>
toError(
importsF,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely should be done better -- maybe with mapN or ap

if (isFile) {
val filename = p.fileName.toString
val ext = Option(filename)
.filter(_.contains("."))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.exists(_.endsWith(".aqua"))

@DieMyst DieMyst merged commit 296c648 into main Aug 18, 2021
@DieMyst DieMyst deleted the js-build branch August 18, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants