Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS build to package and to integration tests #256

Merged
merged 11 commits into from
Aug 31, 2021
Merged

Conversation

DieMyst
Copy link
Member

@DieMyst DieMyst commented Aug 30, 2021

No description provided.

@DieMyst DieMyst marked this pull request as ready for review August 30, 2021 16:21
@DieMyst DieMyst changed the title js integration tests Add JS build to package and to integration tests Aug 30, 2021

const argsString = args.join(" ");

console.log(argsString);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some log prefix?

npm/package.json Outdated
"bin": "index.js",
"bin": {
"aqua": "index.js",
"aqua-js-experimental": "index-experimental.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let it be just aqua-js?

@alari alari linked an issue Aug 31, 2021 that may be closed by this pull request
@DieMyst DieMyst merged commit bc46145 into main Aug 31, 2021
@DieMyst DieMyst deleted the js-integration-tests branch August 31, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile the Aquamarine compiler into JS with ScalaJS
2 participants