Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 types #453

Merged
merged 11 commits into from
Mar 17, 2022
Merged

V3 types #453

merged 11 commits into from
Mar 17, 2022

Conversation

DieMyst
Copy link
Member

@DieMyst DieMyst commented Mar 14, 2022

No description provided.

@DieMyst DieMyst requested a review from alari March 15, 2022 11:48
@DieMyst DieMyst marked this pull request as ready for review March 15, 2022 11:48
alari
alari reviewed Mar 16, 2022
View reviewed changes
backend/ts/src/main/scala/aqua/backend/Definitions.scala
}

case class LabelledProductTypeDef(fields: List[(String, TypeDefinition)]) extends ProductTypeDef {
val tag = "labeledProduct"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why one l?

@DieMyst DieMyst merged commit 2ed1d8c into main Mar 17, 2022
@DieMyst DieMyst deleted the v3-types branch March 17, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alari alari alari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DieMyst @alari