chore(execution-engine): VM execution step negative tests [fixes VM-251] #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raftedproc
added
A-execution-engine
Pull Request Test Coverage Report for Build 4383402664Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mikevoronov
reviewed
Mar 10, 2023
| } | ||
|
|
||
| #[test] | ||
| fn nonstring_in_triplet_for_call() { |
There was a problem hiding this comment.
Let's add 6 more test cases where all of these put into other 2 positions in a call triplet.
| } | ||
|
|
||
| #[test] | ||
| fn ap_scalar_variable_not_found_error() { |
There was a problem hiding this comment.
Suggest naming tests in this file following this pattern
<error_name>_<specific>, so this one would be variable_not_found_ap_scalar, and without error.
raftedproc
force-pushed
the
chore/VM-251-catchable-negative-tests
branch
from
1b708e8
to
fda6559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.