Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(air): demote some AquaVM logging statements #505

Merged
merged 4 commits into from
Mar 10, 2023
Merged

fix(air): demote some AquaVM logging statements #505

merged 4 commits into from
Mar 10, 2023

Conversation

monoid
Copy link
Contributor

@monoid monoid commented Mar 10, 2023 •
edited

Users complain that warn level produces lot of unnecessary logs.

  • join behavior logging is demoted to trace;
  • xor logging is demoted to trace;
  • service error logging is demoted to debug.

@monoid
feat(air): demote xor message to debug
a538bcc 
Users complain that `warn` level produces lot of unnecessary logs.
@monoid monoid requested a review from mikevoronov March 10, 2023 15:08
@linear
Copy link

linear bot commented Mar 10, 2023

VM-260 Demote `xor` error message to `debug` level

Users complain that warn produces lot of unneeded garbage logs.

@monoid monoid self-assigned this Mar 10, 2023
@monoid monoid changed the title feat(air): demote xor message to debug fix(air): demote xor message to debug Mar 10, 2023
@monoid monoid added A-execution-engine area: execution engine of AquaVM C-enhancement category: an issue proposing an enchacement or a PR with one P-high priority: high C-dx category: developer experience improvements labels Mar 10, 2023
mikevoronov
mikevoronov approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@mikevoronov mikevoronov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@coveralls
Copy link

coveralls commented Mar 10, 2023 •
edited

Pull Request Test Coverage Report for Build 4387128819

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.45%
Totals Coverage Status
Change from base Build 4383270508: 0.0%
Covered Lines: 13644
Relevant Lines: 19096
💛 - Coveralls

@monoid monoid changed the title fix(air): demote xor message to debug fix(air): demote some AquaVM logging sattements Mar 10, 2023
@monoid monoid changed the title fix(air): demote some AquaVM logging sattements fix(air): demote some AquaVM logging statements Mar 10, 2023
@monoid monoid merged commit 271b74d into master Mar 10, 2023
@monoid monoid deleted the feat/VM-260-demote-xor-level branch March 10, 2023 18:09
This was referenced Mar 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikevoronov mikevoronov mikevoronov approved these changes

Assignees

@monoid monoid

Labels
A-execution-engine area: execution engine of AquaVM C-dx category: developer experience improvements C-enhancement category: an issue proposing an enchacement or a PR with one P-high priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@monoid @coveralls @mikevoronov