feat(marine-book): update to marine-rs-sdk 0.14.0/marine-rs-sdk-test 0.16.1 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| extern "C" { | ||
| fn curl(cmd: Vec<String>) -> MountedBinaryResult; | ||
| } | ||
| ``` | ||
|
|
||
| Note that to import functions from a host, not from other Wasm modules, `wasm_import_module` must be equal to `"host"`. | ||
| Note that to import functions from a host, not from other Wasm modules, the `extern` block must be marked by `#[host_import]` macro. | ||
|
|
||
| The code above creates a "curl adapter", i.e., a Wasm module that allows other Wasm modules to use the the `curl_request` function, which calls the imported _curl_ binary in this case, to make http calls. Please note that we are wrapping the `extern` block with the `#[marine]` macro and introduce a Marine-native data structure `MountedBinaryResult` as the linked-function return value. |
There was a problem hiding this comment.
here and throughout, i think we just just stick with effector, e.g., curl_effector or curl effecotr, to match with the Glossary and Glossary link-backs.
Suggested change
| The code above creates a "curl adapter", i.e., a Wasm module that allows other Wasm modules to use the the `curl_request` function, which calls the imported _curl_ binary in this case, to make http calls. Please note that we are wrapping the `extern` block with the `#[marine]` macro and introduce a Marine-native data structure `MountedBinaryResult` as the linked-function return value. | |
| The code above creates a "curl effector", i.e., a Wasm module that allows other Wasm modules to use the the `curl_request` function, which calls the imported _curl_ binary in this case, to make http calls. Please note that we are wrapping the `extern` block with the `#[marine]` macro and introduce a Marine-native data structure `MountedBinaryResult` as the linked-function return value. |
There was a problem hiding this comment.
also, the new curl module doesn't use curl_requestany longer. it's nowcurl_getandcurl_post`.
|
|
||
| /// Id of the current service. | ||
| pub service_id: String, | ||
|
|
||
| /// Id of the service creator. | ||
| pub service_creator_peer_id: String, | ||
|
|
||
| /// Id of the host which run this service. | ||
| /// PeerId of the peer who hosts worker with this service. |
There was a problem hiding this comment.
somewhere along the way, marine book needs to reference/define the term worker, e.g., fluencelabs/dev-rewards#46
| @@ -5,7 +5,7 @@ import TabItem from "@theme/TabItem"; | |||
|
|
|||
| The `#[marine]` macro can also wrap a Rust [extern block](https://doc.rust-lang.org/std/keyword.extern.html). In this case, all functions declared in it are considered imported functions. If there are imported functions in some module, say, module A, then | |||
|
|
|||
| * There should be another module, module B, that exports the same functions. The name of module B is indicated in the `link` macro (see examples below) | |||
| * There should be another module, module B, that exports the same functions. The name of module B is indicated in the `module_import` macro (see examples below) | |||
| * Module B should be loaded into `Marine` by the moment the loading of module A starts. Module A cannot be loaded if at least one imported function is absent in `Marine`. | |||
There was a problem hiding this comment.
Suggested change
| * Module B should be loaded into `Marine` by the moment the loading of module A starts. Module A cannot be loaded if at least one imported function is absent in `Marine`. | |
| * Module B should be loaded into `Marine` when the loading of module A starts. Module A cannot be loaded if one or more imported functions are missing. |
| extern "C" { | ||
| fn curl(cmd: Vec<String>) -> MountedBinaryResult; | ||
| } | ||
| ``` | ||
|
|
||
| Note that to import functions from a host, not from other Wasm modules, `wasm_import_module` must be equal to `"host"`. | ||
| Note that to import functions from a host, not from other Wasm modules, the `extern` block must be marked by `#[host_import]` macro. |
There was a problem hiding this comment.
Suggested change
| Note that to import functions from a host, not from other Wasm modules, the `extern` block must be marked by `#[host_import]` macro. | |
| Note that to import functions from a host, as opposed to imports from other Wasm modules, the `extern` block must be marked by `#[host_import]` macro. |
| @@ -337,7 +337,7 @@ pub fn what_o_clock(timezone: String) -> SimpleResult { | |||
| // here we provide the linking info for the curl-adapter module and expose the | |||
| // curl_request method to the facade module | |||
| #[marine] | |||
| #[link(wasm_import_module = "curl_adapter")] | |||
| #[module_import("curl_adapter")] | |||
There was a problem hiding this comment.
i'll update the rest. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.