fix: bug with repeated alias for service [NET-434] #1536

justprosh · 2023-03-28T07:48:44Z

+ a little bit of refactoring

linear · 2023-03-28T07:48:47Z

[2023-03-27T16:20:40.193915Z WARN  particle_services::app_services] Alias `worker-spell` is the same for ca449fcc-aa74-402f-a8d6-a5936a85e946 and ca449fcc-aa74-402f-a8d6-a5936a85e946
[2023-03-27T16:20:40.193936Z WARN  particle_services::app_services] Alias `worker-spell` is the same for ca449fcc-aa74-402f-a8d6-a5936a85e946 and ca449fcc-aa74-402f-a8d6-a5936a85e946
[2023-03-27T16:20:40.193939Z INFO  particle_services::app_services] Persisted service ca449fcc-aa74-402f-a8d6-a5936a85e946 created in 2s 230ms 101us 99ns, aliases: ["worker-spell", "worker-spell", "worker-spell"]

kmd-fl · 2023-03-28T08:38:18Z

particle-services/src/app_services.rs

@@ -73,7 +73,9 @@ pub struct Service {

 impl Service {
    pub fn remove_alias(&mut self, alias: &str) {
-        self.aliases.retain(|a| a.ne(alias));
+        if let Some(pos) = self.aliases.iter().position(|x| *x == alias) {
+            self.aliases.remove(pos);


Maybe we can make self.aliases a set?

Yeah, I think about that, but we must decide which alias we can use in metrics. Now it's just the first element of vec

Yeah, good point.

Also, we should decide for which services with aliases to collect metrics. In the current model, where we create aliases for every deal, it's just too many services, and an uncontrollable amount of services for metrics collection in prometheus.

Maybe we can collect metrics per-worker?

Difficult question. Guess we can discuss it later when we start reworking metrics for spells/workers/so on.

is there any reason to allow several aliases per service?

I really don't know

particle-services/src/app_services.rs

folex · 2023-03-28T15:20:05Z

particle-services/src/app_services.rs

@@ -73,7 +73,9 @@ pub struct Service {

 impl Service {
    pub fn remove_alias(&mut self, alias: &str) {
-        self.aliases.retain(|a| a.ne(alias));


Why retain wasn't enough? 🤔

It is more than enough, I did add_alias and remove_alias symmetrically. Now add_alias adds 1 alias, and remove_alias removes exactly one alias

particle-services/src/app_services.rs

particle-services/src/app_service.rs

fix: bug with repeated alias for service

bc1d755

justprosh requested review from folex and kmd-fl March 28, 2023 07:48

kmd-fl reviewed Mar 28, 2023

View reviewed changes

refactor

a046558

justprosh requested a review from kmd-fl March 28, 2023 12:52

kmd-fl approved these changes Mar 28, 2023

View reviewed changes

folex reviewed Mar 28, 2023

View reviewed changes

particle-services/src/app_services.rs Outdated Show resolved Hide resolved

folex reviewed Mar 28, 2023

View reviewed changes

particle-services/src/app_services.rs Outdated Show resolved Hide resolved

justprosh and others added 5 commits March 30, 2023 19:30

refactoring

1c7412e

fix test

785e2b6

Update app_service.rs

69b20da

refactoring

3daaf1c

refactoring

8803b21

justprosh requested review from folex and kmd-fl March 30, 2023 15:57

Merge branch 'master' into fix_repeated_alias_bug

5bd0f50

justprosh added the e2e Run e2e workflow label Mar 30, 2023

kmd-fl reviewed Mar 30, 2023

View reviewed changes

particle-services/src/app_service.rs Show resolved Hide resolved

kmd-fl approved these changes Mar 30, 2023

View reviewed changes

folex approved these changes Mar 30, 2023

View reviewed changes

justprosh merged commit ff455be into master Mar 31, 2023

justprosh deleted the fix_repeated_alias_bug branch March 31, 2023 09:21

fluencebot mentioned this pull request Mar 31, 2023

chore(master): release rust-peer 0.10.0 #1524

Merged

fluencebot mentioned this pull request Jun 22, 2023

chore(master): release rust-peer 0.13.0 #1635

Merged

fluencebot mentioned this pull request Jul 20, 2023

chore(master): release rust-peer 0.14.0 #1713

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: bug with repeated alias for service [NET-434] #1536

fix: bug with repeated alias for service [NET-434] #1536

justprosh commented Mar 28, 2023 •

edited

Loading

linear bot commented Mar 28, 2023

kmd-fl Mar 28, 2023

justprosh Mar 28, 2023

kmd-fl Mar 28, 2023

justprosh Mar 28, 2023

kmd-fl Mar 28, 2023 •

edited

Loading

folex Mar 30, 2023

justprosh Mar 31, 2023

folex Mar 28, 2023

justprosh Mar 28, 2023

fix: bug with repeated alias for service [NET-434] #1536

fix: bug with repeated alias for service [NET-434] #1536

Conversation

justprosh commented Mar 28, 2023 • edited Loading

linear bot commented Mar 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kmd-fl Mar 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justprosh commented Mar 28, 2023 •

edited

Loading

kmd-fl Mar 28, 2023 •

edited

Loading