-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mailbox): store and return init_peer_id and timestamp [NET-510] #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this shouldn't be marked as done
Documentation has been updated to reflect the changes (if applicable).
This change should be documented somewhere, and I don't see that it was written in Spell Service Proposal or near it.
Btw, I don't know how to treat our Spell Service Proposal; it should be just a spell service documentation page, I guess. But it should be changed with spell service changes.
The release of this PR will increase the major version of spell service and spell lib, right? Since it's a |
Yes, because service API has changed |
🤖 I have created a release *beep* *boop* --- ## [0.5.17](spell-v0.5.16...spell-v0.5.17) (2023-07-27) ### Features * **mailbox:** get_mailbox returns in FIFO order [NET-508] ([#153](#153)) ([715981f](715981f)) * **mailbox:** store and return init_peer_id and timestamp [NET-510] ([#154](#154)) ([333e404](333e404)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
Keep
init_peer_id
for mailbox messages and return timestamps.Motivation
It's crucial to know who and when pushed messages to the mailbox.
Related Issue(s)
Proposed Changes
init_peer_id
from call parametersChecklist
Screenshots (if applicable)
[Add any relevant screenshots or animated GIFs to showcase the changes.]
Additional Notes
[Provide any additional information or context that may be helpful for the reviewer.]
Reviewer Checklist