-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gelf message pack error on valid kubernetes enriched #1291
Comments
Fun fact, it seems only keys with a EDIT: or is it the |
Yaey! I can almost confirm, cause this filter eliminates the errors and all seems to work.
|
I tested:
Doesn't work either and explains the error some people report in the comments there. |
Never seen this (no idea of c), but I could imagine there is an oversight in the valid chars, here... : Lines 779 to 792 in dbd8de7
|
Just checked, it't the |
Closes: fluent#1291 `U+002F / 2f SOLIDUS` is valid in k8s labels Maybe that's the wrong fix, though and k8s labels rather ought to be normalized??
@manuelluis , can you take a look at this issue ? |
The gelf format defines the key as ^[\w.-]*$ : which is chars in the set [A-Za-z0-9_.-], The same problem in: #1166 A generic solution could be replace in the gelf ouput, every char in a key that not match [A-Za-z0-9_.-] with an underscore char: '_' . If this is solution is ok, I can make a pull request with the changes. |
True! Looks like a good idea. |
@manuelluis yes please! |
@manuelluis You can start from #1166 if you want, I only replaced |
Really looking forward for this one... thanks! |
This should be fixed in #1166 . @blaggacao , can you confirm? |
What is the fix for this ? I am using fluent-bit with Azure kubernetics 1.16.1 |
Me too, i'm using fluent-bit 1.3.7 installed with helm (repo stable/fluent-bit, docker image fluent/fluent-bit:1.3.7) but the error persist. |
This issue persists with v3.0.0. |
Bug Report
Version 1.0.6
Gelf output barks on (valid) nested objects from the kubernetes filter.
Already filtered by:
resulting in a sample log message:
barking in
flb_msgpack_gelf_key
, possibly due to a loop error inflb_msgpack_gelf_flatten
The text was updated successfully, but these errors were encountered: