mpack: compilation error on CentOS 6/7

[nokute78]

Bug Report

Describe the bug
Compilation error on CentOS 7.
C99 style of mpack causes. gcc of Cent OS 7 can't compile by default.

e.g.

bool mpack_str_check_no_null(const char* str, size_t bytes) {
    for (size_t i = 0; i < bytes; ++i)

To Reproduce

• Rubular link if applicable:
  None
• Example log message if applicable:
  None
• Steps to reproduce the problem:

$ cmake3 .. && make

Expected behavior
Buildable.

Screenshots
None

Your Environment

• Version used: git master
• Configuration: none
• Environment name and version (e.g. Kubernetes? What version?):
• Server type and version:
• Operating System and version: CentOS 6/7
• Filters and plugins: None

Additional context
Workaround is to use -std=gnu99 or c99.

gcc 5 supports gnu11 by default.
https://www.gnu.org/software/gcc/gcc-5/changes.html

Do we need to check compiler and its version?

diff --git a/lib/mpack-amalgamation-1.0/CMakeLists.txt b/lib/mpack-amalgamation-1.0/CMakeLists.txt
index bbf2ecd..b0fd081 100644
--- a/lib/mpack-amalgamation-1.0/CMakeLists.txt
+++ b/lib/mpack-amalgamation-1.0/CMakeLists.txt
@@ -1,6 +1,6 @@
 set(src
   src/mpack/mpack.c
   )
-
+add_definitions(-std=gnu99)
 add_definitions(-DMPACK_EXTENSIONS=1)
 add_library(mpack-static STATIC ${src})

[edsiper]

Is it because variable declaration inside the loop?

…

On Tue, Jul 16, 2019, 22:58 Takahiro YAMASHITA ***@***.***> wrote: Bug Report *Describe the bug* Compilation error on CentOS 7. C99 style of mpack causes. gcc of Cent OS 7 can't compile by default. e.g. bool mpack_str_check_no_null(const char* str, size_t bytes) { for (size_t i = 0; i < bytes; ++i) *To Reproduce* - Rubular link if applicable: None - Example log message if applicable: None - Steps to reproduce the problem: $ cmake3 .. && make *Expected behavior* Buildable. *Screenshots* None *Your Environment* - Version used: git master - Configuration: none - Environment name and version (e.g. Kubernetes? What version?): - Server type and version: - Operating System and version: CentOS 6/7 - Filters and plugins: None *Additional context* Workaround is to use -std=gnu99 or c99. gcc 5 supports gnu11 by default. https://www.gnu.org/software/gcc/gcc-5/changes.html Do we need to check compiler and its version? diff --git a/lib/mpack-amalgamation-1.0/CMakeLists.txt b/lib/mpack-amalgamation-1.0/CMakeLists.txt index bbf2ecd..b0fd081 100644--- a/lib/mpack-amalgamation-1.0/CMakeLists.txt+++ b/lib/mpack-amalgamation-1.0/CMakeLists.txt@@ -1,6 +1,6 @@ set(src src/mpack/mpack.c )-+add_definitions(-std=gnu99) add_definitions(-DMPACK_EXTENSIONS=1) add_library(mpack-static STATIC ${src}) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1441?email_source=notifications&email_token=AAC2INSPQ5UARMNB6CL4DYTP7XHXZA5CNFSM4IEBIJTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7PLMJA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC2INS4PNL3MSJEHQUVIYLP7XHXZANCNFSM4IEBIJTA> .

[nokute78]

Yes.

Note: libjemalloc also uses C99 style declaration. We can build it on CentOS.
It may be better to compile in the same way.

fluent-bit/lib/jemalloc-5.1.0/src/jemalloc.c

Line 744 in 15f6a9e

for (size_t i = 0; i < vlen; i++) {

[edsiper]

@nokute78 what's the specific compiler version ? I would like to pass the info to mpack author

[nokute78]

Maybe gcc 4.8.x. Default version of CentOS7.
I will tell you tommorow. I can't access my PC now..

By the way , similar issue and PR are already reported on mpack repo.
PR is not merged and closed.
ludocode/mpack#67
ludocode/mpack#68

[edsiper]

I've posted the issue in mpack repo:

ludocode/mpack#69

[nokute78]

@edsiper Thank you.

[edsiper]

update:

• latest mpack has been merged
• refs: 900c40c a1bd32a

fixed, thanks again.

[nokute78]

@edsiper Thank you.