Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C89/99 #67

Closed
dirkson opened this issue Mar 19, 2019 · 0 comments
Closed

C89/99 #67

dirkson opened this issue Mar 19, 2019 · 0 comments

Comments

@dirkson
Copy link
Contributor

dirkson commented Mar 19, 2019 •
edited
Loading

Hey there!

Currently your code fails to compile when c_std=gnu89. However, the only C99 feature that you appear to use is the ability to declare variables inside for loops. Would you be interested in a PR that moves the variable declarations out of the for() loops, and thus makes your code compaticle with gnu89?

Cheers!

Edit: It was only a little work, so I just went ahead and submitted the PR: #68
@dirkson dirkson closed this as completed Mar 20, 2019
@nokute78 nokute78 mentioned this issue Jul 17, 2019
Closed
@edsiper edsiper mentioned this issue Jul 18, 2019
Closed
ludocode added a commit that referenced this issue Jul 16, 2021
@ludocode
Fix additional for loop declarations for gnu89 support
c2debb2 
This builds on the for loop changes merged from #68, making the same
changes to the unit test suite.

Fixes #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dirkson