Revert "out_kafka: make MSVC compatible (#1179)" #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 69fffab. Bakashar Kemerbay (and many other Windows users) reports that it causes an immediate abort on Windows environments. In particular, it causes abort even when they does not use out_kafka. For example, I can confirm that even the following command does not work on a vanilla Windows server. $ fluent-bit.exe -i dummy -o stdout This is because librdkafka is dependent on OpenSSL (ssleay32.dll and libeay32.dll), which most Windows servers do not have. Hence fluent-bit.exe always fails due to missing DLL dependencies. So we have to revert this, and revisit it after resolving the dependency issue. Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
|
Hello Can someone please tell me where I can download the Windows td-agent-bit installer for the version that doesn't have this missing DLL issue? I've got to get this agent installed this weekend. |
|
Hello Can someone please tell me where I can download the Windows td-agent-bit installer for the version that doesn't have this missing DLL issue? I've got to get this agent installed this weekend.
Try the following installer:
#960 (comment)
This fix is currently being subject to community testing (it's in the
win32-next branch, but not in master).
If you can confirm it works, I appreciate if you can comemnt back here.
It should help this fix to land on the next stable release.
…On Sat, Dec 21, 2019 at 06:34:13PM -0800, Daniel Thompson wrote:
Hello Can someone please tell me where I can download the Windows td-agent-bit installer for the version that doesn't have this missing DLL issue? I've got to get this agent installed this weekend.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1832 (comment)
|
|
Thank you! Can you verify if I have the right link? Is this it? Does it include all the supporting files needed for Windows or just the executable? Sorry, but I only have the build environment for Linux. I wish they would leave up the links to previous versions.. |
|
On Sat, Dec 21, 2019 at 07:37:44PM -0800, Daniel Thompson wrote:
Thank you! Can you verify if I have the right link? Is this it?
https://ci.appveyor.com/project/fluent/fluent-bit-2e87g/builds/29673141/job/1l1dnwvwyv9tkygi/artifacts
That's it. if you prefer 64-bit version, use this one:
https://ci.appveyor.com/project/fluent/fluent-bit-2e87g/build/job/mdvsuaopyeeegxcs/artifacts
Does it include all the supporting files needed for Windows or just the executable? Sorry, but I only have the build environment for Linux. I wish they would leave up the links to previous versions..
This includes `fluent-bit.exe` and you shoud be able to run it on Windows.
(I've tested it on vanilla Windows Server 2019, and it worked)
|
|
Hi @fujimotos, Are the "standard" plugins a part of this Windows build? Do I need to install the "include" directory with the C header files in the production server? When I run it I'm getting the following: We use this same configuration file on Linux with no issues. |
|
@JungleGenius the missing plugins mentioned above are Linux "only" |
phiremande
pushed a commit
to phiremande/fluent-bit
that referenced
this pull request
Dec 24, 2019
This reverts commit 69fffab. Bakashar Kemerbay (and many other Windows users) reports that it causes an immediate abort on Windows environments. In particular, it causes abort even when they does not use out_kafka. For example, I can confirm that even the following command does not work on a vanilla Windows server. $ fluent-bit.exe -i dummy -o stdout This is because librdkafka is dependent on OpenSSL (ssleay32.dll and libeay32.dll), which most Windows servers do not have. Hence fluent-bit.exe always fails due to missing DLL dependencies. So we have to revert this, and revisit it after resolving the dependency issue. Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
hassanfarid
pushed a commit
to hassanfarid/fluent-bit
that referenced
this pull request
Dec 27, 2019
This reverts commit 69fffab. Bakashar Kemerbay (and many other Windows users) reports that it causes an immediate abort on Windows environments. In particular, it causes abort even when they does not use out_kafka. For example, I can confirm that even the following command does not work on a vanilla Windows server. $ fluent-bit.exe -i dummy -o stdout This is because librdkafka is dependent on OpenSSL (ssleay32.dll and libeay32.dll), which most Windows servers do not have. Hence fluent-bit.exe always fails due to missing DLL dependencies. So we have to revert this, and revisit it after resolving the dependency issue. Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com> Signed-off-by: Hassan Farid <hassan.seth@gmail.com>
This was referenced Jan 8, 2020
edsiper
pushed a commit
that referenced
this pull request
Jan 23, 2020
This reverts commit 69fffab. Bakashar Kemerbay (and many other Windows users) reports that it causes an immediate abort on Windows environments. In particular, it causes abort even when they does not use out_kafka. For example, I can confirm that even the following command does not work on a vanilla Windows server. $ fluent-bit.exe -i dummy -o stdout This is because librdkafka is dependent on OpenSSL (ssleay32.dll and libeay32.dll), which most Windows servers do not have. Hence fluent-bit.exe always fails due to missing DLL dependencies. So we have to revert this, and revisit it after resolving the dependency issue. Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 69fffab.
Bakashar Kemerbay (and many other Windows users) reports that it
causes an immediate abort on Windows environments. In particular,
it causes abort even when they does not use out_kafka.
For example, I can confirm that even the following command does
not work on a vanilla Windows server.
This is because librdkafka is dependent on OpenSSL (ssleay32.dll
and libeay32.dll), which most Windows servers do not have. Hence
fluent-bit.exe always fails due to missing DLL dependencies.
So we have to revert this, and revisit it after resolving the
dependency issue.
Signed-off-by: Fujimoto Seiji fujimoto@clear-code.com