Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "out_kafka: make MSVC compatible (#1179)" #1832

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Revert "out_kafka: make MSVC compatible (#1179)" #1832

merged 1 commit into from
Dec 23, 2019

Commits on Dec 20, 2019

  1. Revert "out_kafka: make MSVC compatible (fluent#1179)" 

    This reverts commit 69fffab.

Bakashar Kemerbay (and many other Windows users) reports that it
causes an immediate abort on Windows environments. In particular,
it causes abort even when they does not use out_kafka.

For example, I can confirm that even the following command does
not work on a vanilla Windows server.

    $ fluent-bit.exe -i dummy -o stdout

This is because librdkafka is dependent on OpenSSL (ssleay32.dll
and libeay32.dll), which most Windows servers do not have. Hence
fluent-bit.exe always fails due to missing DLL dependencies.

So we have to revert this, and revisit it after resolving the
dependency issue.

Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
    Fujimoto Seiji committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    c6e02c5 View commit details
    Browse the repository at this point in the history