CMakeLists.txt: Miniz: compile as a static lib

[ThomasDevoogdt]

#6711

Buildroot enforces globally wide that all packages are dynamically linked (if BR2_SHARED_LIBS), so that means that these options slept through the subdirectories. The libminiz.so is not installed by cmake, causing the fluent-bit to crash. This patch forces libminiz to be compiled statically.

Note that this option doesn't have a dedicated prefix, adding one would require a change in libminiz. That is not the scope of this PR, if someone can take this up, feel free to do so.

Signed-off-by: Thomas Devoogdt thomas.devoogdt@barco.com

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[leonardo-albertovich]

I think the best would be for us to comply and install the SO but I doubt that's something we can tackle at the moment.

The only question I have is if overriding that in the root cmakelists.txt at that stage would be the right thing to do or if it could lead to side effects in other use cases.

I took a look at the cmakelists.txt file included in the library and it seems that since they don't use cmake we wrote a small one which combined with the fact that we are using a fairly old version of miniz makes me think that maybe we should make that override there on a localized way to avoid causing issues in the future when someone else adds something to the root cmakelists.txt file.

What do you think?

[ThomasDevoogdt]

I think the best would be for us to comply and install the SO but I doubt that's something we can tackle at the moment.

The only question I have is if overriding that in the root cmakelists.txt at that stage would be the right thing to do or if it could lead to side effects in other use cases.

I took a look at the cmakelists.txt file included in the library and it seems that since they don't use cmake we wrote a small one which combined with the fact that we are using a fairly old version of miniz makes me think that maybe we should make that override there on a localized way to avoid causing issues in the future when someone else adds something to the root cmakelists.txt file.

What do you think?

I didn't know at the time that the CMakeLists.txt file in the lib was custom, so adapting makes sense.

For other libs, this is done:

  option(JANSSON_BUILD_SHARED_LIBS  OFF)

So I would add the MINIZ_BUILD_SHARED_LIBS option and turn it off in the root CMakeLists.txt.

[leonardo-albertovich]

Please excuse me, I mistakenly verified the wrong branch, the current branch seems to be using miniz 3 which does use cmake.

In that case, do you think we could do something like saving the current value of BUILD_SHARED_LIBS before line 513 and restore it after line 514 in order to limit the forced behavior?

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[ThomasDevoogdt]

Closed this PR as Miniz has disabled the shared library build by default in commit richgel999/miniz@0ce345c, which got bumped in commit 47fd29a.