Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists.txt: Miniz: compile as a static lib #6723

Closed
wants to merge 1 commit into from
Closed

CMakeLists.txt: Miniz: compile as a static lib #6723

wants to merge 1 commit into from

Commits on Jan 23, 2023

  1. CMakeLists.txt: Miniz: compile as a static lib 

    fluent#6711

Buildroot enforces globally wide that all packages are
dynamically linked (if BR2_SHARED_LIBS), so that means
that these options slept through the subdirectories.
The libminiz.so is not installed by cmake, causing the
fluent-bit to crash. This patch forces libminiz to be
compiled statically.

Note that this option doesn't have a dedicated prefix,
adding one would require a change in libminiz. That is
not the scope of this PR, if someone can take this up,
feel free to do so.

Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
    @ThomasDevoogdt
    ThomasDevoogdt committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b82a0d5 View commit details
    Browse the repository at this point in the history