fix image #192
Merged
fix image #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhu733756
force-pushed
the
modify-image
branch
3 times, most recently
from
95b96c0
to
b632083
Compare
Merged
zhu733756
force-pushed
the
modify-image
branch
from
b632083
to
5587f10
Compare
benjaminhuo
reviewed
Feb 10, 2022
| @@ -9,7 +9,7 @@ RUN CGO_ENABLED=0 go build -i -ldflags '-w -s' -o /fluentd/fluentd-watcher /code | |||
|
|
|||
| # Fluentd main image | |||
| FROM alpine:3.13 | |||
| LABEL Description="Fluentd docker image" Vendor="Kubesphere Organization" Version="1.14.4" | |||
| LABEL Description="Fluentd docker image" Vendor="KubeSphere Organization" Version="1.14.4" | |||
There was a problem hiding this comment.
Should be Fluent Organization ?
benjaminhuo
reviewed
Feb 10, 2022
| @@ -11,7 +11,7 @@ spec: | |||
| bind: 0.0.0.0 | |||
| port: 24224 | |||
| replicas: 1 | |||
| image: zhu733756/fluentd:config-reloader | |||
| image: kubesphere/fluentd:v1.14.4-amd64 | |||
There was a problem hiding this comment.
Maybe fluentd:v1.14.4-operator is better because this image will finally be migrated to fluent org and there should already have fluentd:v1.14.4
zhu733756
force-pushed
the
modify-image
branch
from
5587f10
to
3f7e042
Compare
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
zhu733756
force-pushed
the
modify-image
branch
from
3f7e042
to
dd64a30
Compare
benjaminhuo
approved these changes
Feb 10, 2022
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
zhu733756
force-pushed
the
modify-image
branch
from
1695591
to
f84d085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhu733756 zhu733756@kubesphere.io