Add fluentd examples #194
Merged
Add fluentd examples #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
benjaminhuo
reviewed
Feb 10, 2022
zhu733756
commented
Feb 10, 2022
| @@ -163,7 +169,24 @@ func (b *Buffer) Params(_ plugins.SecretLoader) (*params.PluginStore, error) { | |||
| } | |||
|
|
|||
| if b.Path != nil { | |||
| ps.InsertPairs("path", *b.Path) | |||
| if strings.HasPrefix(*b.Path, "/buffers") { | |||
There was a problem hiding this comment.
Buffer PVC mounts with /buffers.
zhu733756
force-pushed
the
add-fluentd-examples
branch
2 times, most recently
from
f533a64
to
fdd6de8
Compare
benjaminhuo
reviewed
Feb 10, 2022
controllers/fluentd_controller.go
Outdated
| @@ -197,7 +197,7 @@ func (r *FluentdReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
| return ctrl.NewControllerManagedBy(mgr). | |||
| For(&fluentdv1alpha1.Fluentd{}). | |||
| Owns(&corev1.ServiceAccount{}). | |||
| Owns(&appsv1.Deployment{}). | |||
| Owns(&appsv1.StatefulSet{}). | |||
| Owns(&corev1.Service{}). | |||
| Owns(&corev1.PersistentVolumeClaim{}). | |||
There was a problem hiding this comment.
no need to owns PersistentVolumeClaim now?
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
zhu733756
force-pushed
the
add-fluentd-examples
branch
from
fdd6de8
to
535716d
Compare
benjaminhuo
approved these changes
Feb 10, 2022
8 tasks
zhu733756
commented
Feb 10, 2022
| @@ -34,6 +34,8 @@ type FluentdSpec struct { | |||
| DisableService bool `json:"disableService,omitempty"` | |||
| // Numbers of the Fluentd instance | |||
| Replicas *int32 `json:"replicas,omitempty"` | |||
| // Numbers of the workers in Fluentd instance | |||
| Workers *int32 `json:"workers,omitempty"` | |||
There was a problem hiding this comment.
Support multi workers in a single pod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhu733756 zhu733756@kubesphere.io
Points:
This pr needs to be merged before #192