Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CI templates for fluent-operator #248

Merged
merged 1 commit into from
Mar 24, 2022
Merged

feat: Add CI templates for fluent-operator #248

merged 1 commit into from
Mar 24, 2022

Conversation

mangoGoForward
Copy link
Member

Signed-off-by: mango xu.weiKyrie@foxmail.com

What this PR does / why we need it:

Add CI templates for fluentbit-operator.

Which issue(s) this PR fixes:

Fixes #207

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

- [Other doc]: https://github.com/fluent/fluent-operator/pull/242

@mangoGoForward
Copy link
Member Author

please have a look. @zhu733756

@zhu733756 zhu733756 changed the title feat: Add CI templates for fluentbit-operator feat: Add CI templates for fluent-operator Mar 24, 2022
@zhu733756
Copy link
Member

please have a look. @zhu733756

Thanks for the great contribution!

@mangoGoForward
Copy link
Member Author

Seems those yaml file's end need a blank line, and I forgot to add.

@zhu733756
Copy link
Member

Seems those yaml file's end need a blank line, and I forgot to add.

No matter, you can implement it by git forced pushing.

Signed-off-by: mango <xu.weiKyrie@foxmail.com>

Add CI templates for fluentbit-operator

Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@mangoGoForward
Copy link
Member Author

Seems those yaml file's end need a blank line, and I forgot to add.

No matter, you can implement it by git forced pushing.

Done.

@benjaminhuo
Copy link
Member

@mangoGoForward This is a great supplement to the current workflow, thanks for the contribution!
And thanks @zhu733756 's review

@benjaminhuo benjaminhuo merged commit 2885c57 into fluent:master Mar 24, 2022
@mangoGoForward mangoGoForward deleted the feat/pr-template branch March 24, 2022 02:50
@benjaminhuo benjaminhuo mentioned this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI templates for fluentbit-operator
4 participants