Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scheduler support for fluentbit & fluentd #771

Merged
merged 2 commits into from Jun 3, 2023

Conversation

ksdpmx
Copy link
Collaborator

@ksdpmx ksdpmx commented Jun 2, 2023

What this PR does / why we need it:

allow customers to specify custom scheduler for fluentbit and fluentd pods

Which issue(s) this PR fixes:

Fixes #758

Does this PR introduced a user-facing change?

add scheduler support for fluentbit & fluentd

Additional documentation, usage docs, etc.:


Signed-off-by: Jason Zhang <ksdpmx@gmail.com>
Signed-off-by: jasonz <3256083+ksdpmx@users.noreply.github.com>
@benjaminhuo
Copy link
Member

@ksdpmx Thanks for this, I'll merge this for now.
Don't forget that we have fluentbit collector crd and controller as well which need changes like this too https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/collector_types.go#L32

@benjaminhuo benjaminhuo merged commit b2a709e into fluent:master Jun 3, 2023
6 checks passed
@ksdpmx ksdpmx deleted the scheduler branch June 6, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom scheduler support
2 participants