feat: add scheduler support for fluentbit collector

[ksdpmx]

What this PR does / why we need it:

allow customers to specify custom scheduler for fluentbit collector as requested from this comment. along with minor typo fix.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?

allow customers to specify custom scheduler for fluentbit collector

Additional documentation, usage docs, etc.:

[ksdpmx]

2023-06-06T03:10:30Z ERROR Reconciler error {"controller": "collector", "controllerGroup": "fluentbit.fluent.io", "controllerKind": "Collector", "Collector": {"name":"fluent-bit-collector","namespace":"fluent"}, "namespace": "fluent", "name": "fluent-bit-collector", "reconcileID": "b0128934-0ce5-4a21-9105-aa7df920cddd", "error": "error when handling finalizer: resource name may not be empty"}

btw i don't really agree with this review.

delete it directly.

resources haven't been generated before calling Delete() which leads to the remaining finalizer for collector.

Why does not delete the clusterrole and clusterrolebinding?

for this review, does it make sense to add an owner reference in the managed clusterrole and clusterrolebinding for gc controller, given this controller is not supposed to have permission to delete clusterrole/clusterrolebinding?

[benjaminhuo]

2023-06-06T03:10:30Z ERROR Reconciler error {"controller": "collector", "controllerGroup": "fluentbit.fluent.io", "controllerKind": "Collector", "Collector": {"name":"fluent-bit-collector","namespace":"fluent"}, "namespace": "fluent", "name": "fluent-bit-collector", "reconcileID": "b0128934-0ce5-4a21-9105-aa7df920cddd", "error": "error when handling finalizer: resource name may not be empty"}

btw i don't really agree with this review.

delete it directly.

resources haven't been generated before calling Delete() which leads to the remaining finalizer for collector.

Why does not delete the clusterrole and clusterrolebinding?

for this review, does it make sense to add an owner reference in the managed clusterrole and clusterrolebinding for gc controller, given this controller is not supposed to have permission to delete clusterrole/clusterrolebinding?

@wanjunlei @wenchajun would you take a look at @ksdpmx‘s opinion?

[benjaminhuo]

2023-06-06T03:10:30Z ERROR Reconciler error {"controller": "collector", "controllerGroup": "fluentbit.fluent.io", "controllerKind": "Collector", "Collector": {"name":"fluent-bit-collector","namespace":"fluent"}, "namespace": "fluent", "name": "fluent-bit-collector", "reconcileID": "b0128934-0ce5-4a21-9105-aa7df920cddd", "error": "error when handling finalizer: resource name may not be empty"}

btw i don't really agree with this review.

delete it directly.

resources haven't been generated before calling Delete() which leads to the remaining finalizer for collector.

Why does not delete the clusterrole and clusterrolebinding?

for this review, does it make sense to add an owner reference in the managed clusterrole and clusterrolebinding for gc controller, given this controller is not supposed to have permission to delete clusterrole/clusterrolebinding?

You're welcome to create a PR to fix whatever you think it's a problem and @wanjunlei @wenchajun will review that

[ksdpmx]

does it make sense to add an owner reference in the managed clusterrole and clusterrolebinding for gc controller, given this controller is not supposed to have permission to delete clusterrole/clusterrolebinding?

fluentbit collector is a namespace-scoped resource which cannot own other cluster-scoped resources.

Cluster-scoped dependents can only specify cluster-scoped owners. In v1.20+, if a cluster-scoped dependent specifies a namespaced kind as an owner, it is treated as having an unresolvable owner reference, and is not able to be garbage collected.

https://kubernetes.io/docs/concepts/architecture/garbage-collection/#owners-dependents

[benjaminhuo]

@ksdpmx have added you as the fluent operator maintainer, thanks for your contribution! @wanjunlei @wenchajun @patrick-stephens