Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm: remove .libs explicitly #99

Merged
merged 1 commit into from
Jun 12, 2020
Merged

rpm: remove .libs explicitly #99

merged 1 commit into from
Jun 12, 2020

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jun 12, 2020

remove_files("ext/**/.{o,la,a}") removes .o,.la,.a, but
not for .libs/.o, .libs/.la, .libs/*.a so explicitly removes
.libs directory.

@kenhys
rpm: remove .libs explicitly
180cd90 
remove_files("ext/**/*.{o,la,a}") removes *.o,*.la,*.a, but
not for .libs/*.o, .libs/*.la, .libs/*.a so explicitly removes
.libs directory.
@kenhys
Copy link
Contributor Author

kenhys commented Jun 12, 2020

I'll check filelist again.

@kenhys
Copy link
Contributor Author

kenhys commented Jun 12, 2020

It was expected.

 diff -u before.txt after.txt
--- before.txt  2020-06-12 10:52:42.911706321 +0900
+++ after.txt   2020-06-12 10:56:27.374246376 +0900
@@ -2798,15 +2798,6 @@
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/ffi_c.so
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs/libffi.la
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs/libffi.lai
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs/libffi.so
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs/libffi.so.8
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs/libffi.so.8.1.0
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs/libffi_convenience.a
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs/libffi_convenience.a(D)
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/.libs/libffi_convenience.la
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/Makefile
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/config.log
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/config.status
@@ -2827,12 +2818,6 @@
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.deps
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.deps/.dirstamp
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.dirstamp
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.libs
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.libs/closures.o
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.libs/java_raw_api.o
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.libs/prep_cif.o
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.libs/raw_api.o
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/.libs/types.o
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/closures.lo
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/java_raw_api.lo
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/prep_cif.lo
@@ -2842,11 +2827,6 @@
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/.deps
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/.deps/.dirstamp
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/.dirstamp
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/.libs
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/.libs/ffi64.o
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/.libs/ffiw64.o
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/.libs/unix64.o
-/opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/.libs/win64.o
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/ffi64.lo
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/ffiw64.lo
 /opt/td-agent/lib/ruby/gems/2.4.0/gems/ffi-1.13.1/ext/ffi_c/libffi-x86_64-linux/src/x86/unix64.lo
@@ -6913,8 +6893,6 @@
 /usr/lib/.build-id/3f/5d8e51813f76c735b8fd4569dee884948122f6
 /usr/lib/.build-id/41
 /usr/lib/.build-id/41/2e06bc4f709155a5dc48965d55fc1e633d9880
-/usr/lib/.build-id/43
-/usr/lib/.build-id/43/e47ad73ffa059ecabe8b5084b65cb283688830
 /usr/lib/.build-id/44
 /usr/lib/.build-id/44/ceb3e7223d42a69fe04c39d1133f33f86bcbaa
 /usr/lib/.build-id/45

@kenhys kenhys requested a review from cosmo0920 June 12, 2020 01:58
@cosmo0920 cosmo0920 merged commit ac8ff97 into master Jun 12, 2020
@cosmo0920 cosmo0920 deleted the fix-fake-removed-files branch June 12, 2020 02:19
@kenhys kenhys mentioned this pull request Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenhys @cosmo0920