Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive old thrift and mark in_flume as obsoleted for Flume NG #11

Merged
merged 5 commits into from
Oct 25, 2016

Conversation

cosmo0920
Copy link
Contributor

Related to #10.

We should provide in_flume for Flume legacy users until 0.2.0 and display obsoleted message for Flume NG users.

@@ -32,8 +32,8 @@ class FlumeOutput < BufferedOutput

def initialize
require 'thrift'
require 'fluent/plugin/thrift/flume_types'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this require order changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiously, this change prevents the following error in test:

E
=================================================================================================================================================================================================
Error: test_write(FlumeOutputTest): NameError: uninitialized constant Status
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/thrift/thrift_source_protocol.rb:88:in `<class:Append_result>'
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/thrift/thrift_source_protocol.rb:83:in `<module:ThriftSourceProtocol>'
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/thrift/thrift_source_protocol.rb:10:in `<top (required)>'
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/out_flume.rb:38:in `require'
/Users/hhatake/Github/fluent-plugin-flume/lib/fluent/plugin/out_flume.rb:38:in `initialize'
/Users/hhatake/Github/fluent-plugin-flume/vendor/bundle/ruby/2.3.0/gems/fluentd-0.12.20/lib/fluent/test/base.rb:44:in `new'
/Users/hhatake/Github/fluent-plugin-flume/vendor/bundle/ruby/2.3.0/gems/fluentd-0.12.20/lib/fluent/test/base.rb:44:in `initialize'
/Users/hhatake/Github/fluent-plugin-flume/vendor/bundle/ruby/2.3.0/gems/fluentd-0.12.20/lib/fluent/test/input_test.rb:28:in `initialize'
/Users/hhatake/Github/fluent-plugin-flume/vendor/bundle/ruby/2.3.0/gems/fluentd-0.12.20/lib/fluent/test/output_test.rb:51:in `initialize'
/Users/hhatake/Github/fluent-plugin-flume/test/plugin/test_out_flume.rb:16:in `new'
/Users/hhatake/Github/fluent-plugin-flume/test/plugin/test_out_flume.rb:16:in `create_driver'
/Users/hhatake/Github/fluent-plugin-flume/test/plugin/test_out_flume.rb:89:in `test_write'
     86:   def test_write
     87:     time = Time.parse("2011-12-21 13:14:15 UTC").to_i
     88: 
  => 89:     d = create_driver
     90:     d.emit({"k11"=>"v11", "k12"=>"v12"}, time)
     91:     d.emit({"k21"=>"v21", "k22"=>"v22"}, time)
     92:     d.run
=================================================================================================================================================================================================

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... okay.

@repeatedly repeatedly merged commit 3f26b67 into fluent:master Oct 25, 2016
@cosmo0920
Copy link
Contributor Author

Thanks!

@cosmo0920 cosmo0920 deleted the revive-old-thrift branch October 26, 2016 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants