Do not remove runtime package #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll create another PR to update images. |
kenhys
added a commit
to kenhys/fluentd-kubernetes-daemonset
that referenced
this pull request
Jul 10, 2024
Closes: fluent#1492 related: fluent/fluentd-docker-image#383 Reported by @gpapaz Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd-kubernetes-daemonset
that referenced
this pull request
Jul 10, 2024
Closes: fluent#1492 related: fluent/fluentd-docker-image#383 Reported by @gpapaz Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
|
I'll check effection to $buildDeps. |
|
|
But removed runtime is reported against k8s images, not fluentd docker image. |
fluent#372 Above pull request introduces "apt-get purge '*-dev'", it is intended to remove only needless development packages, but actually --auto-remove removes also runtime packages. This behavior is not intended at all, so do not apply --auto-remove when purging '*-dev'. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
|
I see! Thanks for the investigation! |
kenhys
force-pushed
the
not-purge-runtime
branch
from
cad0ddf
to
e29dc89
Compare
kenhys
added a commit
to kenhys/fluentd-kubernetes-daemonset
that referenced
this pull request
Jul 10, 2024
Closes: fluent#1492 related: fluent/fluentd-docker-image#383 Reported by @gpapaz Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd-kubernetes-daemonset
that referenced
this pull request
Jul 10, 2024
Closes: fluent#1492 related: fluent/fluentd-docker-image#383 Reported by @gpapaz When runtime package was not specified explicitly, apt-get purge --auto-remove removes runtime packages. So not to be removed libsasl2-2 and libsasl2-module by apt-get purge --auto-remove '*-dev', install them explicitly in beforehand. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
added a commit
to kenhys/fluentd-kubernetes-daemonset
that referenced
this pull request
Jul 10, 2024
Closes: fluent#1492 related: fluent/fluentd-docker-image#383 Reported by @gpapaz When runtime package was not specified explicitly, apt-get purge --auto-remove removes runtime packages. So not to be removed libsasl2-2 by apt-get purge --auto-remove '*-dev', install them explicitly in beforehand. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
|
Reconsidered to withdraw it. |
kenhys
added a commit
to kenhys/fluentd-kubernetes-daemonset
that referenced
this pull request
Jul 10, 2024
Closes: fluent#1492 related: fluent/fluentd-docker-image#383 Reported by @gpapaz When runtime package was not specified explicitly, apt-get purge --auto-remove removes runtime packages. So not to be removed libsasl2-2 by apt-get purge --auto-remove '*-dev', install them explicitly in beforehand. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#372 Above pull request introduces "apt-get purge '*-dev'", it is intended to remove only needless development packages, but actually --auto-remove removes also runtime packages.
This behavior is not intended at all, so drop --auto-remove option.
Before: with --auto-remove
After: without --auto-remove