Various issues with http://docs.fluentd.org/articles/in_forward

[client9]

Hi team,

Thanks for the nice documentation.

However, I found some problems with http://docs.fluentd.org/articles/in_forward

re: This plugin uses MessagePack for the internal protocol.

1. Actually it accepts JSON too.

echo -n '["debug.access", 1308466941, {"a":1}]' | telnet localhost 24224

works fine.. this shows up in the log

2011-06-19 07:02:21 +0000 debug.access: {"a":1}

as does multiple values:

 echo -n '["debug.access", 1308466941, {"a":1}]["debug.access", 1308466942, {"b":2}]' | telnet localhost 24224

and the alternate format

echo -n '["debug.access", [[1308466941, {"a":1}], [1308466942, {"b":2}]]]' | telnet localhost 24224

1. It would be nice to have the exact field and type formats documented (Instead of having to decode binary data streams).
2. Explicitly say what the timestamp is... it appears to be a standard Unix-seconds-since-Epoch. Using unsigned int 32 in messagepack?
3. I think the 'message' is a string, but a fully formed JSON object. ' {"a":1, ... } '

re: examples

This example is incorrect?

  ["myapp.access", [1308466941, {"a"=>1}], [1308466942, {"b"=>2}]]

1. missing '[' in front of '[1308466941'
2. it's missing a final ']'
3. also since JSON is actually supported, perhaps using JSON ':' instead of '=>' might make sense.

Hmm, I just realised this is on github, so I can fork and make a pull request?

thanks all!

nickg

[repeatedly]

Thanks for pointing out.

Actually it accepts JSON too.

You are right. in_forward can accept JSON too.

Explicitly say what the timestamp is... it appears to be a standard Unix-seconds-since-Epoch. Using unsigned int 32 in messagepack?

Hmm... we don't fix the timestamp type because it depends on system. Time.now.to_i is used by default.
Maybe, 32bit integer is good for 32bit / 64bit mix environment.

This example is incorrect?

Yes, it is incorrect.

Hmm, I just realised this is on github, so I can fork and make a pull request?

If you okay, please send the pull request :)

[client9]

sorry for delay.. I'll work on pull request soon!

[repeatedly]

@client9 ping?

[client9]

thanks for reminder… working on it and getting my dev environment working….

On May 2, 2014, at 17:13, Masahiro Nakagawa notifications@github.com wrote:

@client9 ping?

—
Reply to this email directly or view it on GitHub.

[repeatedly]

Merged the PR 👍