Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract RecordFilter Mixin into compat #1044

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Extract RecordFilter Mixin into compat #1044

merged 1 commit into from
Jun 14, 2016

Conversation

cosmo0920
Copy link
Contributor

@tagomoris tagomoris merged commit 8efe111 into fluent:master Jun 14, 2016
@tagomoris
Copy link
Member

Good change :)

@tagomoris
Copy link
Member

@cosmo0920 Could you move some others in lib/fluent/mixin into compat?
I wrote that task description very shortly, but it includes these in fact :P

@cosmo0920
Copy link
Contributor Author

@tagomoris OK, I'll try it tomorrow.

@cosmo0920 cosmo0920 deleted the extract-record-filter-mixin branch June 14, 2016 09:08
@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Jun 15, 2016 •
edited
Loading

Umm, compat module migration needed modules are HandleTagNameMixin, SetTimeKeyMixin and SetTagKeyMixin?
If other modules also should extract from mixin.rb, please let me know.

@cosmo0920 cosmo0920 mentioned this pull request Jun 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosmo0920 @tagomoris