LoggerInitializer updated to create directory when it doesn't exists. #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -268,7 +268,8 @@ def initialize(path, level, chuser, chgroup, opts) | |||
|
|
|||
| def init | |||
| if @path && @path != "-" | |||
| @io = File.open(@path, "a") | |||
| Dir.mkdir(File.dirname(@path)) unless File.exists?(@path) | |||
There was a problem hiding this comment.
It fails when the file (@path) doesn't exist and directory (File.dirname(@path)) already exists, and when the parent directories of directory (File.dirname(File.dirname(@path))) doesn't exist.
It's better to use FileUtils.mkdir_p(File.dirname(@path)) unless Dir.exist?(File.dirname(@path))
There was a problem hiding this comment.
File.exists? (and Dir.exists?) are deprecated methods. Use File.exist? instead.
|
Please check tests and CI results. |
|
Thanks @tagomoris for the feedback. I'll give it a look and make the proper updates 👍 |
tagomoris
added
v0.14
moreinfo
|
@bmandrade ping? |
|
Sorry @tagomoris , I'll try to take on this as soon as possible |
|
closed by #2732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this change is to allow fluentd to create a directory that is passed by --log and don't exists on the system.
Cheers