fix to raise ConfigError for type missing, and its tests #1202

tagomoris · 2016-09-02T00:58:41Z

Previously, it raises NeMethodError for nil.

2016-09-02 09:45:47 +0900 [error]: unexpected error error="undefined method `to_sym' for nil:NilClass\nDid you mean?  to_s"
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/registry.rb:39:in `lookup'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/plugin.rb:146:in `new_impl'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/plugin.rb:104:in `new_output'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/agent.rb:133:in `add_match'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/agent.rb:69:in `block in configure'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/agent.rb:63:in `each'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/agent.rb:63:in `configure'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/root_agent.rb:86:in `configure'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/engine.rb:119:in `configure'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/engine.rb:93:in `run_configure'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/supervisor.rb:673:in `run_configure'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/supervisor.rb:435:in `block in run_worker'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/supervisor.rb:606:in `main_process'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/supervisor.rb:431:in `run_worker'
  2016-09-02 09:45:47 +0900 [error]: /Users/tagomoris/github/fluentd/lib/fluent/command/fluentd.rb:271:in `<top (required)>'
  2016-09-02 09:45:47 +0900 [error]: bin/fluentd:5:in `require'
  2016-09-02 09:45:47 +0900 [error]: bin/fluentd:5:in `<main>'

This fix makes the situation better.

2016-09-02 09:48:17 +0900 [error]: config error file="example/match_without_type.conf" error="Missing 'type' parameter on <match> directive"

fix #1201.

repeatedly · 2016-09-02T01:33:48Z

lib/fluent/agent.rb

@@ -63,6 +63,7 @@ def configure(conf)
      conf.elements('filter', 'match').each { |e|
        pattern = e.arg.empty? ? '**' : e.arg
        type = e['@type']
+        raise ConfigError, "Missing 'type' parameter on <#{e.name}> directive" unless type


Should use @type, not type.

Right... I copied it from other error.

…issing-type fix to raise ConfigError for type missing, and its tests

fix to raise ConfigError for type missing, and its tests

ce0f2db

repeatedly reviewed Sep 2, 2016
View reviewed changes

use @type instead of type

8c04641

tagomoris merged commit 81b4330 into master Sep 2, 2016

tagomoris deleted the raise-configuration-errors-for-missing-type branch September 2, 2016 04:46

repeatedly pushed a commit that referenced this pull request Sep 5, 2016

Merge pull request #1202 from fluent/raise-configuration-errors-for-m…

1e49ea6

…issing-type fix to raise ConfigError for type missing, and its tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix to raise ConfigError for type missing, and its tests #1202

fix to raise ConfigError for type missing, and its tests #1202

tagomoris commented Sep 2, 2016

repeatedly Sep 2, 2016

tagomoris Sep 2, 2016

fix to raise ConfigError for type missing, and its tests #1202

fix to raise ConfigError for type missing, and its tests #1202

Conversation

tagomoris commented Sep 2, 2016

repeatedly Sep 2, 2016

Choose a reason for hiding this comment

tagomoris Sep 2, 2016

Choose a reason for hiding this comment