LabeledTSVParser error handling and default parameters. #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValuesParser is not delete the output of time key like other do so.
Time key should be deleted when it has used for fluentd internal time like TSVParser, CSVParser do so.
LabeledTSVParser error handling problem
The error of "time_format parameter is ignored" puts message to $log.warn.
It should raise ConfigError.
The default of time_key for LabeledTSVParser
I think LabeledTSVParser should be 'time' for the default of
time_key
.This behavior causes confusion and not same as ApacheParser, JSONParser and RegexpParser.
It cannot seamless upgrade from in_tail with regex or apache apache2 nginx and so on.
There configuration usualy have time_format but not it has time_key. like http://ltsv.org/
If it not 'time' for the default of
time_key
, it could result using current time when time_format is blank.footnote
ValuesParser was used by LabeledTSVParser, TSVParser, CSVParser