Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secondary calculation should consider retry_max_times. fix #1449 #1452

Merged
merged 2 commits into from
Feb 10, 2017
Merged

Secondary calculation should consider retry_max_times. fix #1449 #1452

merged 2 commits into from
Feb 10, 2017

Conversation

repeatedly
Copy link
Member

Current secondary transition calculation checks only retry_timeout parameter, but
it should consider retry_max_times.

@repeatedly repeatedly added bug Something isn't working v0.14 labels Feb 8, 2017
@repeatedly
Copy link
Member Author

@tagomoris Could you check this?

@repeatedly
Copy link
Member Author

@tagomoris ping?

tagomoris
tagomoris approved these changes Feb 10, 2017
View reviewed changes
Copy link
Member

@tagomoris tagomoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@repeatedly repeatedly merged commit e221494 into master Feb 10, 2017
@repeatedly repeatedly deleted the fix-secondary-calc branch February 10, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tagomoris tagomoris tagomoris approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@repeatedly @tagomoris