Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port certificates generating command from secure-forward #1818

Merged
merged 8 commits into from
Jan 17, 2018
Merged

Port certificates generating command from secure-forward #1818

merged 8 commits into from
Jan 17, 2018

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Jan 15, 2018 •
edited
Loading

I ported secure-forward's certificates generating command from fluent-plugin-secure-forward.

Fix #1795

@cosmo0920 cosmo0920 mentioned this pull request Jan 15, 2018
Closed
@cosmo0920 cosmo0920 changed the title Port certificates generating command from secure-forward. Fix #1795 Port certificates generating command from secure-forward Jan 15, 2018
@ashishtilara
Copy link

Awesome and Thank you @cosmo0920,

Just one comment on this, how do I configure.

cert_country:  'US',
cert_state:    'CA',
cert_locality: 'Mountain View',
cert_common_name: 'Fluentd Forward CA',

like I did it in my repo ,
https://github.com/ashishtilara/fluentd-ssl-generator/blob/master/generate

USAGE: generate  DIR_PATH  PRIVATE_KEY_PASSPHRASE COUNTRY STATE LOCALITY COMMON_NAME

@cosmo0920
Copy link
Contributor Author

Just one comment on this, how do I configure.

cert_country:  'US',
cert_state:    'CA',
cert_locality: 'Mountain View',
cert_common_name: 'Fluentd Forward CA',

They are hard-coded for now.

@repeatedly
Copy link
Member

If make these values configurable, need to use --country like option instead of command arguments.

repeatedly
repeatedly reviewed Jan 16, 2018
View reviewed changes
bin/fluent-ca-generate Outdated
#!/usr/bin/env ruby

$LOAD_PATH.unshift(File.join(__dir__, 'lib'))
require 'fileutils'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This require should be in lib/fluent/command/ca_generate.rb?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

@repeatedly
Copy link
Member

repeatedly commented Jan 16, 2018 •
edited
Loading

@cosmo0920 How about adding options? Default is same with existing one.

@cosmo0920
Copy link
Contributor Author

I added options which are requested by @ashishtilara.

@ashishtilara
Copy link

Thank you @cosmo0920 :)

@repeatedly repeatedly merged commit 82121fa into fluent:master Jan 17, 2018
@repeatedly
Copy link
Member

Thx!

@cosmo0920 cosmo0920 deleted the add-ca-generate-command branch January 17, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@repeatedly repeatedly repeatedly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cosmo0920 @ashishtilara @repeatedly