-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_in_tail: Show more information of test_unwatched_files_should_be_removed #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_removed It's unstable on macOS but hard to debug due to less information: https://github.com/fluent/fluentd/runs/6872721774?check_suite_focus=true ``` 2022-06-14T02:25:40.1951760Z Failure: test_unwatched_files_should_be_removed(TailInputTest::path) 2022-06-14T02:25:40.1968250Z /Users/runner/work/fluentd/fluentd/test/plugin/test_in_tail.rb:1615:in `test_unwatched_files_should_be_removed' 2022-06-14T02:25:40.1968820Z 1612: waiting(20) { sleep 0.1 until Dir.glob("#{@tmp_dir}/*.txt").size == 0 } # Ensure file is deleted on Windows 2022-06-14T02:25:40.1969220Z 1613: waiting(5) { sleep 0.1 until d.instance.instance_variable_get(:@Tails).keys.size <= 0 } 2022-06-14T02:25:40.1969500Z 1614: 2022-06-14T02:25:40.1969770Z => 1615: assert_equal(0, d.instance.instance_variable_get(:@Tails).keys.size) 2022-06-14T02:25:40.1970010Z 1616: 2022-06-14T02:25:40.1970200Z 1617: d.instance_shutdown 2022-06-14T02:25:40.1970500Z 1618: end 2022-06-14T02:25:40.1970720Z <0> expected but was 2022-06-14T02:25:40.1970910Z <1> ``` Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Hmm, can't reproduce on CI in this pull request. |
https://github.com/fluent/fluentd/runs/6875305374?check_suite_focus=true
🤔 |
ashie
added a commit
that referenced
this pull request
Jun 14, 2022
…moved Showing whole @Tails seems too heavy on CI environment: ``` 2022-06-14T07:17:55.0456030Z Error: test_unwatched_files_should_be_removed(TailInputTest::path): SystemStackError: stack level too deep 2022-06-14T07:17:55.2289960Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:179:in `bind_call' 2022-06-14T07:17:55.2290470Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:179:in `object_address_group' 2022-06-14T07:17:55.2291380Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/pp.rb:241:in `pp_object' ... 2022-06-14T07:17:55.5055170Z /Users/runner/work/fluentd/fluentd/test/plugin/test_in_tail.rb:1615:in `test_unwatched_files_should_be_removed' 2022-06-14T07:17:55.5055350Z 1612: waiting(20) { sleep 0.1 until Dir.glob("#{@tmp_dir}/*.txt").size == 0 } # Ensure file is deleted on Windows 2022-06-14T07:17:55.5055520Z 1613: waiting(5) { sleep 0.1 until d.instance.instance_variable_get(:@Tails).keys.size <= 0 } 2022-06-14T07:17:55.5055590Z 1614: 2022-06-14T07:17:55.5055670Z => 1615: assert_equal( 2022-06-14T07:17:55.5055730Z 1616: { 2022-06-14T07:17:55.5055810Z 1617: files: [], 2022-06-14T07:17:55.5055880Z 1618: tails: {} ``` Follow up for #3784 Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unstable on macOS but hard to debug due to less information:
https://github.com/fluent/fluentd/runs/6872721774?check_suite_focus=true
Signed-off-by: Takuro Ashie ashie@clear-code.com
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Docs Changes:
Release Note: