Periodic flush on in_tail plugin for multiline format #668 #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need testers for this patch. |
| @@ -262,6 +264,7 @@ def parse_multilines(lines, tail_watcher) | |||
| lb = tail_watcher.line_buffer | |||
| es = MultiEventStream.new | |||
| if @parser.has_firstline? | |||
| tail_watcher.line_buffer_flusher.reset unless tail_watcher.line_buffer_flusher.nil? | |||
There was a problem hiding this comment.
if tail_watcher.line_buffer_flusher
|
I corrected the points that were pointed out. |
|
I re-ran tests |
|
Thanks!!! |
|
Ah, wait. This patch is for v0.12. |
|
After update patch and send to master, I will merge it. |
|
I send the patch to master with #775 . |
|
#775 is merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote patches for #668.
Please check this.
Thanks.