-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fluent-bit): Added hot-reload support #384
Conversation
571222e
to
fad340d
Compare
This PR is waiting for some external testing and I'll mark it as ready once this has happened. |
f4e9850
to
617516c
Compare
@edsiper @naseemkullah do you want to take a look at the changes here? The structural changes are required to support hot-reload as user-overridable files should be in a leaf directory to enable direct Kubernetes ConfigMap or Secret mounting. I'm not sure what the side effects of these changes are but when all paths in the config are absolute I've tested that everything works as expected. |
I think @patrick-stephens would be times better than me to review these changes |
@edsiper there are some fundamental questions about how Fluent Bit config and workdir works that I asked @patrick-stephens and he passed on to @leonardo-albertovich (I think I got the GH user correct). |
617516c
to
c415e66
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
c415e66
to
a76300d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, some good improvements here as well as the hot reload support.
I would add something to the docs to explain how hot reload is being done via a watcher sidecar. I think we should look at the requirements on port/webserver usage vs just signals too to confirm.
@patrick-stephens this change came from the two Fluent Bit prototype charts I've been working on (see below) and has been extensively tested (as part of the aggregator chart). |
@stevehipwell I'm happy with this change to merge whenever you are. |
I found that the 6b04c1c#diff-d501e88794e6225fbd785cd688bd23d39ffa17e1cafa6f9a704a5b95a73a10d7L88-L89 |
@kyontan |
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
No description provided.