Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limits the length of the grafana dashboard uid to 40 to prevent grafa… #509

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

mheers
Copy link
Contributor

@mheers mheers commented May 23, 2024

…na import error

When trying to import the dashboard json the grafana container throws logger=provisioning.dashboard type=file name=file t=2024-05-23T06:54:30.144967684Z level=error msg="failed to save dashboard" file=/tmp/dashboards/fluentbit-fluent-bit-fluent-bit.json error="uid too long, max 40 characters"

With this fix the length of the uid is trunctated to 40 chars.

@stevehipwell
Copy link
Collaborator

Isn't the output of sha256sum fixed length?

CC @captainpro-eng

@mheers
Copy link
Contributor Author

mheers commented May 23, 2024

It is fixed to 64 chars and so too long for grafana

@captainpro-eng
Copy link
Contributor

Isn't the output of sha256sum fixed length?

CC @captainpro-eng

hi, can we remove this imp. , I was using old Grafana where if I set uid null not generating unique uid. After upgrading Grafana if we pass null it is working.

@marcofranssen
Copy link

Would be great to get this fix in or as an alternative we simply do not define the uid in the dashboard. Both solutions work, tested in my own setup.

@stevehipwell
Copy link
Collaborator

@mheers could you please update this PR to set the uid field to null and remove the fluent-bit.dashboard.uid function added in #503.

@mheers
Copy link
Contributor Author

mheers commented Jun 4, 2024

@stevehipwell done

@stevehipwell
Copy link
Collaborator

@mheers could you rebase this PR?

@mheers
Copy link
Contributor Author

mheers commented Jun 7, 2024

@stevehipwell rebased and cleaned history

@marcofranssen
Copy link

@mheers the dco is failing. Maybe fix that to not delay the release of this fix

Signed-off-by: Marcel Heers <info@heers.it>
@mheers
Copy link
Contributor Author

mheers commented Jun 7, 2024

@marcofranssen fixed. thanks

@stevehipwell
Copy link
Collaborator

@mheers you need to update the version and release notes annotations in Chart.yaml so the workflows will pass.

@mheers
Copy link
Contributor Author

mheers commented Jun 11, 2024

@stevehipwell updated

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell merged commit b42b00e into fluent:main Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants