Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "satisfy respectively" assertion (#882) #1043

Merged

Conversation

Projects
None yet
4 participants
@vanashimko
Copy link
Contributor

commented May 6, 2019

Add "satisfy respectively" assertion, similar to xUnit Assert.Collection (#882).

@dennisdoomen
Copy link
Member

left a comment

Absolutely love this feature!

@dennisdoomen dennisdoomen requested a review from jnyrup May 7, 2019

@jnyrup
Copy link
Collaborator

left a comment

Great implementation 👍

I'm not entirely sure about the name SatisfyRespectively.
From the name, it doesn't immediately strikes me what it's supposed to do.
@dennisdoomen IIRC you have sometimes got valuable feedback from your Twitter network for brainstorming?

@vanashimko vanashimko force-pushed the vanashimko:issue/882-satisfy-respectively branch 2 times, most recently from 10e43e9 to cc703dc May 7, 2019

@vanashimko

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Hmm, tests failed two times in a row at AppVeyor, based on the tests failed, I suppose it's related to #1022. @jnyrup @dennisdoomen can I restart build somehow other than pushing new changes? Tests are passing stable on my machine, so fails are most likely not related to my changes.

@vanashimko vanashimko force-pushed the vanashimko:issue/882-satisfy-respectively branch from cc703dc to 7f7f30b May 11, 2019

@jnyrup

jnyrup approved these changes May 13, 2019

@jnyrup jnyrup merged commit 9c87318 into fluentassertions:master May 15, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jnyrup

This comment has been minimized.

Copy link
Collaborator

commented May 15, 2019

@vanashimko Thanks for the contribution to Fluent Assertions.
Look out for your name in the next release.

@vanashimko vanashimko deleted the vanashimko:issue/882-satisfy-respectively branch May 15, 2019

@mdilovar

This comment has been minimized.

Copy link

commented Jun 5, 2019

Which version will this be available in?

@jnyrup

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

@mdilovar It will be available in the next release, which will be 5.7.0.
I can't give a release date, but I can assure you that we're also eager to get the next release out.
We're working as I write on weeding out the last issues before being ready to push the release button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.