Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "satisfy respectively" assertion (#882) #1043

Merged
merged 3 commits into from
May 15, 2019
Merged

Add "satisfy respectively" assertion (#882) #1043

merged 3 commits into from
May 15, 2019

Conversation

ishimko
Copy link
Contributor

@ishimko ishimko commented May 6, 2019

Add "satisfy respectively" assertion, similar to xUnit Assert.Collection (#882).

dennisdoomen
dennisdoomen approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely love this feature!

Src/FluentAssertions/Collections/GenericCollectionAssertions.cs Outdated Show resolved Hide resolved
@dennisdoomen dennisdoomen requested a review from jnyrup May 7, 2019 06:30
jnyrup
jnyrup reviewed May 7, 2019
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation 👍

I'm not entirely sure about the name SatisfyRespectively.
From the name, it doesn't immediately strikes me what it's supposed to do.
@dennisdoomen IIRC you have sometimes got valuable feedback from your Twitter network for brainstorming?

Src/FluentAssertions/Common/StringExtensions.cs Outdated Show resolved Hide resolved
Src/FluentAssertions/Collections/GenericCollectionAssertions.cs Outdated Show resolved Hide resolved
Src/FluentAssertions/Collections/GenericCollectionAssertions.cs Show resolved Hide resolved
@ishimko ishimko force-pushed the issue/882-satisfy-respectively branch 2 times, most recently from 10e43e9 to cc703dc Compare May 7, 2019 08:51
@ishimko
Copy link
Contributor Author

ishimko commented May 7, 2019

Hmm, tests failed two times in a row at AppVeyor, based on the tests failed, I suppose it's related to #1022. @jnyrup @dennisdoomen can I restart build somehow other than pushing new changes? Tests are passing stable on my machine, so fails are most likely not related to my changes.

@ishimko ishimko force-pushed the issue/882-satisfy-respectively branch from cc703dc to 7f7f30b Compare May 11, 2019 07:52
@jnyrup jnyrup merged commit 9c87318 into fluentassertions:master May 15, 2019
@jnyrup
Copy link
Member

jnyrup commented May 15, 2019

@vanashimko Thanks for the contribution to Fluent Assertions.
Look out for your name in the next release.

@jnyrup jnyrup mentioned this pull request May 15, 2019
Closed
@ishimko ishimko deleted the issue/882-satisfy-respectively branch May 15, 2019 20:12
@mdilovar
Copy link

mdilovar commented Jun 5, 2019 •
edited
Loading

Which version will this be available in?

@jnyrup
Copy link
Member

jnyrup commented Jun 5, 2019

@mdilovar It will be available in the next release, which will be 5.7.0.
I can't give a release date, but I can assure you that we're also eager to get the next release out.
We're working as I write on weeding out the last issues before being ready to push the release button.

@jnyrup jnyrup mentioned this pull request Nov 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishimko @jnyrup @mdilovar @dennisdoomen