Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failure message for occurrence regex

Conversation

ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Apr 26, 2022

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

In my daily work, I was really pissed about the fact, that I have forgotten to include the actual subject in the failure message.
This PR fixes my own fault. :)

@ITaluone ITaluone force-pushed the fix-match-regex-failure-message branch 2 times, most recently from f639b70 to 47b0f10 Compare Apr 26, 2022
@coveralls
Copy link

coveralls commented Apr 26, 2022

Pull Request Test Coverage Report for Build 2231208701

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.607%

Totals Coverage Status
Change from base Build 2228236076: 0.0%
Covered Lines: 8502
Relevant Lines: 8769

💛 - Coveralls

@ITaluone ITaluone force-pushed the fix-match-regex-failure-message branch from 47b0f10 to a038796 Compare Apr 26, 2022
@ITaluone ITaluone force-pushed the fix-match-regex-failure-message branch from a038796 to 4989324 Compare Apr 27, 2022
jnyrup
jnyrup approved these changes Apr 27, 2022
@dennisdoomen dennisdoomen merged commit c33006c into fluentassertions:develop Apr 27, 2022
1 check passed
@ITaluone ITaluone deleted the fix-match-regex-failure-message branch Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants