Custom rules were not executed on dictionary equivalency assertions #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
requested changes
Aug 9, 2018
| @@ -1085,6 +1085,7 @@ public void When_a_property_is_write_only_it_should_be_ignored() | |||
| action.Should().NotThrow(); | |||
| } | |||
|
|
|||
|
|
|||
| @@ -6,6 +6,7 @@ | |||
| using System.Linq; | |||
| using FluentAssertions.Common; | |||
| using FluentAssertions.Equivalency; | |||
| using FluentAssertions.Execution; | |||
There was a problem hiding this comment.
I guess this change can be left out as well?
| @@ -1221,5 +1221,37 @@ public void When_a_nested_dictionary_value_doesnt_match_it_should_throw() | |||
| act.Should().Throw<XunitException>() | |||
| .WithMessage("Expected*String*JValue*"); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void SomeOtherTest() | |||
| //----------------------------------------------------------------------------------------------------------- | ||
| var dictOne = new Dictionary<string, double> | ||
| { | ||
| { "a", 1.2345 }, |
There was a problem hiding this comment.
Very nitpicking, but I would use C# 6 dictionary initializers.
| @@ -553,7 +553,7 @@ public void When_an_assertion_rule_is_added_it_appear_in_the_exception_message() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void When_multiple_asertion_rules_are_added_they_should_be_evaluated_last_to_first() | |||
| public void When_multiple_assertion_rules_are_added_they_should_be_evaluated_last_to_first() | |||
There was a problem hiding this comment.
Depending on how strict/isolated you want to be on commits, this should be moved to it's own commit.
dennisdoomen
force-pushed
the
CustomAssertionRul
branch
from
1d91d40
to
a9df2c7
Compare
jnyrup
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #530