fix: avoid corruption after using test_load #1063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9708040.
hluaces
changed the title
hluaces
commented
Apr 28, 2024
| @@ -0,0 +1,2 @@ | |||
| void create() { | |||
There was a problem hiding this comment.
This test does nothing on its own, but I need a different object I can load/destroy from the 1063.c file.
When using `test_load` on a loaded object the object list ends up corrupted. The details are obscure, but if doing this reproduces the error: 1. Load any object in memory. Check that both `find_object` and `children()` return the single existing object 2. Run `test_load` on the object. Check that `find_object` returns `0` 3. Destroy and create the object. `children()` will now return an array with two duplicates of the same object or, sometimes, a `0` and the existing copy of the object In some instances i've seen different objects returned by `children()` than the one being passed as path (this usually happened with clones). This PR tries to work around it. I've also reverted fluffos#843 because I believe this PR fixes the underlying cause for the issue, not just the symptom. All credit goes to Zoilder (one of the developers on our mud) that happened to fix this a long time ago. We're just sending these fixes upstream since we're starting to update our outdated driver. Please let me know if there's anything I should fix. I've tried to add a proper test for this, but I don't know if that's the location you're expecting for it.
hluaces
force-pushed
the
hluaces/fix/test-load-not-working
branch
from
ad8b83e
to
b14001c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
test_loadon a loaded object the object list ends up corrupted. The details are obscure, but doing this reproduces the error:find_object()andchildren()return the single existing objecttest_loadon the object. At this pointfind_object()will probably return0(sometimes it doesn't)load_object()again.children()will now return an array with two duplicates of the same object or, sometimes, a0and the existing copy of the objectIn some instances i've seen different objects returned by
children()than the one being passed as path (this usually happened with clones).This PR tries to work around it. I've also reverted #843 because I believe this PR fixes the underlying cause for the issue, not just the symptom.
All credit goes to Zoilder (one of the developers on our mud) that happened to fix this a long time ago. We're just sending these fixes upstream since we're starting to update our outdated driver.
Please let me know if there's anything I should change in the PR. I've tried to add a proper test for this, but I don't know if that's the location you're expecting for it.