Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick Random port allocation #2621

Merged

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Feb 18, 2023

  • Validate port allocating policy before setting up

  • Expose configurable option for port allocating policy

  • Fix unit tests

  • Fix static check

  • Fix static check

  • Fix comments for SetupRuntimePortAllocator()

  • Support configurable port allocate policy


Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Feb 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…dnative#2580)

* Validate port allocating policy before setting up

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Expose configurable option for port allocating policy

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Fix unit tests

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Fix static check

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Fix static check

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Fix comments for `SetupRuntimePortAllocator()`

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Support configurable port allocate policy

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

---------

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang merged commit 885b5a7 into fluid-cloudnative:release-0.8 Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants