Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

del metadata sync && del duplicate metrics #3380

Merged
merged 2 commits into from
Aug 4, 2023
Merged

del metadata sync && del duplicate metrics #3380

merged 2 commits into from
Aug 4, 2023

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Aug 4, 2023 •
edited
Loading

Ⅰ. Describe what this PR does

  1. delete metadata sync of juicefs. At present, the metadata sync of juicefs is realized through ls -lR. When the size of files is too large, the result returned by this command will cause exec to occupy a large amount of memory. And metadata sync is not necessary for juicefs.
  2. duplicate getMetrics in juicefs runtime controller, make it only get once.

Ⅱ. Does this pull request fix one issue?

fix #3381

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zwwhdls
del metadata sync && del duplicate metrics
b42783d 
Signed-off-by: zwwhdls <zww@hdls.me>
@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #3380 (d9f8861) into master (cbaed52) will increase coverage by 0.09%.
Report is 3 commits behind head on master.
The diff coverage is 58.33%.

❗ Current head d9f8861 differs from pull request most recent head 973dc38. Consider uploading reports for the commit 973dc38 to get more accurate results

@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
+ Coverage   64.46%   64.55%   +0.09%     
==========================================
  Files         434      441       +7     
  Lines       25805    25919     +114     
==========================================
+ Hits        16634    16732      +98     
- Misses       7194     7210      +16     
  Partials     1977     1977
Files Changed Coverage Δ
api/v1alpha1/dataprocess_types.go 100.00% <ø> (ø)
pkg/common/constants.go 100.00% <ø> (ø)
pkg/ddc/alluxio/operate.go 0.00% <0.00%> (ø)
pkg/ddc/base/operation.go 0.00% <0.00%> (ø)
pkg/ddc/base/operation_helm.go 0.00% <0.00%> (ø)
pkg/ddc/efc/operate.go 0.00% <0.00%> (ø)
pkg/ddc/jindofsx/operate.go 0.00% <0.00%> (ø)
pkg/ddc/juicefs/metadata.go 60.00% <ø> (+12.79%) ⬆️
pkg/ddc/juicefs/operate.go 0.00% <0.00%> (ø)
pkg/ddc/thin/operate.go 0.00% <0.00%> (ø)
... and 10 more

... and 2 files with indirect coverage changes

@zwwhdls
Copy link
Member Author

zwwhdls commented Aug 4, 2023

/test fluid-e2e

@zwwhdls
log level
973dc38 
Signed-off-by: zwwhdls <zww@hdls.me>
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
12.8% 12.8% Duplication

@TrafalgarZZZ
Copy link
Member

/test fluid-e2e

cheyang
cheyang approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Aug 4, 2023
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit c1d91d5 into fluid-cloudnative:master Aug 4, 2023
10 checks passed
cheyang pushed a commit to cheyang/fluid that referenced this pull request Aug 21, 2023
@zwwhdls @cheyang
del metadata sync && del duplicate metrics (fluid-cloudnative#3380)
cb48267 
* del metadata sync && del duplicate metrics

Signed-off-by: zwwhdls <zww@hdls.me>

* log level

Signed-off-by: zwwhdls <zww@hdls.me>

---------

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: cheyang <cheyang@163.com>
TrafalgarZZZ pushed a commit to TrafalgarZZZ/fluid that referenced this pull request Feb 28, 2024
@zwwhdls @TrafalgarZZZ
del metadata sync && del duplicate metrics (fluid-cloudnative#3380)
1bc90cd 
* del metadata sync && del duplicate metrics

Signed-off-by: zwwhdls <zww@hdls.me>

* log level

Signed-off-by: zwwhdls <zww@hdls.me>

---------

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ TrafalgarZZZ mentioned this pull request Feb 28, 2024
Merged
fluid-e2e-bot bot pushed a commit that referenced this pull request Feb 28, 2024
@TrafalgarZZZ @zwwhdls
del metadata sync && del duplicate metrics (#3380) (#3738)
212d6e8 
* del metadata sync && del duplicate metrics



* log level



---------

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Co-authored-by: Weiwei <zww@hdls.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheyang cheyang cheyang approved these changes

@TrafalgarZZZ TrafalgarZZZ Awaiting requested review from TrafalgarZZZ

Assignees

@cheyang cheyang

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] JuiceFSRuntime controller pod oomed in a fixed period
3 participants
@zwwhdls @TrafalgarZZZ @cheyang